-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
See if we can better handle book paging to fit more context on a line…
…, without causing text loss after reaching character limit.
- Loading branch information
Showing
1 changed file
with
52 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f272a7e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit causes my book´s text to be distorted and completely broken. Before this it was working perfectly fine. Paste: http://pastebin.com/M8FMQZmJ
This is a severe problem for me and my new players who gets the book named Ultracraft.
f272a7e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried your book with the previous version, and I found several lines which were missing, that this commit fixes, looks like there was a bug with line paging however your file highlighted...
Just pushed something to fix a pager bug, see if that fixes it.
I tried your book config, and it looks like you might want to adjust your book a little, to deal with the colour formatting change.
(We no longer reset the colour on each line)
f272a7e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you,
it seems to be fixed!
But I need also to manually add some blank lines which
are not added by " " (space) now. Can you add some special
line separator line \n ? Thx.
Here is edited book: http://pastebin.com/rxH2RQCk
I need a blank new line where the "&7\n" character is.
Edit: I noticed the &r is not resetting color, is it intended to be like this?
f272a7e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The colour system is not made by us, we're just passing the information to the minecraft server, which passes it to the client.
The reason we have to do so much work to it first, is to work out how much text to send per page, as we have to send each page as a separate text file.
I was adding a &0 to the start of each line before, but since i've found out that colour codes count as letters in the page limit, I removed them to increase the number of letters you can use on each page.
Prior to this we weren't checking the page limits only the line limits.
You can still make blank lines by adding a colour code on an empty line.
f272a7e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I appreciate you work ;)
Edit: Just tested, I tried &0 or &1 but it didn´t work.