Add further choices for LibVersion #649
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #648 by adding additional choices for
hdf5::property::LibVersion
. The available choices are constraint based on the available version of HDF5:One important thing to notice:
When the specific versions (V18, V110, etc.) where first introduced in v1.10.2,
HDF5_LIBVER_LATEST
was removed from theH5F_libver_t
enum and instead#define
'd to refer to the actual latest version among the now added enum valuesV18
,V110
, etc. Therefore, starting with v1.10.2LibVersion::Latest
is no longer distinguishable from the actual latest version (e.g.,LibVersion::V110
). I therefore removed the printing of "Latest" in favor of printing the actual version number in caseLibVersion::Latest
was specified. I did not see a better alternative, as the cases in this switch-statement need to remain disjoint.