Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add further choices for LibVersion #649

Merged
merged 2 commits into from
May 17, 2024

Conversation

FlyingSamson
Copy link
Contributor

Implements #648 by adding additional choices for hdf5::property::LibVersion. The available choices are constraint based on the available version of HDF5:

  • Starting with v1.10.2: V18 and V110
  • Starting with v1.12.0: V112
  • Starting with v1.13.0 (!): V114
  • The current master which is bound to become 1.15 one day will additionally add V116 (not yet included in the PR)

One important thing to notice:
When the specific versions (V18, V110, etc.) where first introduced in v1.10.2, HDF5_LIBVER_LATEST was removed from the H5F_libver_t enum and instead #define'd to refer to the actual latest version among the now added enum values V18, V110, etc. Therefore, starting with v1.10.2 LibVersion::Latest is no longer distinguishable from the actual latest version (e.g., LibVersion::V110). I therefore removed the printing of "Latest" in favor of printing the actual version number in case LibVersion::Latest was specified. I did not see a better alternative, as the cases in this switch-statement need to remain disjoint.

Copy link
Collaborator

@yuelongyu yuelongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good to me

Copy link
Collaborator

@jkotan jkotan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good

@jkotan jkotan merged commit 0b197da into ess-dmsc:master May 17, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants