Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to skip ghost force reduction #4777

Draft
wants to merge 2 commits into
base: python
Choose a base branch
from

Conversation

capomav
Copy link
Contributor

@capomav capomav commented Aug 22, 2023

Fixes #4556

@RudolfWeeber
Copy link
Contributor

Lgtm so far. Next step are

  • skip setting up the collect_ghost_forces_comm in the constructor of RegularDecomposiotion (srccore/cell_systems/RegularDecomposition.cpp) if the flag is ture.
  • Modify the testsuite/python/lj.py so that it runs one test without skipping the ghost force reduction and another with skipping it. That second test will fail.
  • check RegularDecomposition::init_cell_neighbors() to make sure, that the neighborship of ghost cells is set up correctly
  • Modify the short range loop to also run on pairs of ghost cells and their red_neighbors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eliminate the need for a ghost force reduction
2 participants