Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(video): Update to not delay when pushing a frame #90

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Oct 15, 2024

Description

Change from 5 ms delay when pushing a frame if the queue of 1 is full to a 0 (no delay).

Motivation and Context

Allows emulation to run faster and simply skip frames which are generated while the current frame finishes rendering.

How has this been tested?

Playing NES and GBC roms in unlocked (fastest) emulation - seeing that they run faster now.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 self-assigned this Oct 15, 2024
@finger563 finger563 added enhancement New feature or request video performance labels Oct 15, 2024
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit 3b94d8c into main Oct 15, 2024
3 checks passed
@finger563 finger563 deleted the feat/no-frame-send-delay branch October 15, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant