Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve genesis emulation #88

Merged
merged 8 commits into from
Oct 14, 2024
Merged

Improve genesis emulation #88

merged 8 commits into from
Oct 14, 2024

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Sep 29, 2024

Description

  • Update genesis emulation VDP_CYCLES_PER_FRAME to actually be correct for better emulation
  • Update how audio emulation accuracy configuration is set (CMakeLists.txt)
  • Actually mix both sound outputs from genesis hardware into single buffer
  • Update sdkconfig some

Motivation and Context

Makes genesis much more enjoyable to play on this hardware :)

How has this been tested?

Building and running on box-3-emu and listening to how much better the genesis sound emulation is and seeing how much better it runs (and esp. when sound is off!)

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

With sound (slower, but sound is much improved):

improved-genesis-compressed.mp4

Muted (buttery smooth):

muted-sonic.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 self-assigned this Sep 29, 2024
Copy link

github-actions bot commented Sep 29, 2024

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit 3f72f4c into main Oct 14, 2024
3 checks passed
@finger563 finger563 deleted the feat/genesis-improvements branch October 14, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant