ISSUE-140: WebformMetadataDate wrongly array filters empties #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aksm
added
bug
DiegoPino
requested changes
Jun 9, 2022
| } | ||
| } | ||
| foreach ($value as $item) { | ||
| $filtered_value = array_filter($item); |
There was a problem hiding this comment.
I think your elseif is in the wrong spot. Basically
On any array_filter filter operation we can do a is_array($value) ? array_filter…… : …..
There was a problem hiding this comment.
Ok, took some doing to figure out what I was doing, but testing the below commit seems to get rid of the warning.
DiegoPino
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #140
@DiegoPino Gave this a shot, but not sure I understood all about the issue so glad to make additional changes.