Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-21: esmero-php gets a proper Patch binary and WACZ #22

Merged
merged 5 commits into from
Dec 3, 2020

Conversation

DiegoPino
Copy link
Member

See #21

bad, bad busy box

Before

patch -d
patch: unrecognized option: d
BusyBox v1.30.1 (2019-06-12 17:51:55 UTC) multi-call binary.

Usage: patch [OPTIONS] [ORIGFILE [PATCHFILE]]

	-p N	Strip N leading components from file names
	-i DIFF	Read DIFF instead of stdin
	-R	Reverse patch
	-N	Ignore already applied patches
	-E	Remove output files if they become empty
	--dry-run	Don't actually change files

After

patch -d
patch: option requires an argument -- 'd'
patch: Try 'patch --help' for more information.

Good. This solves:

 Applying patches for drupal/search_api
    patches/1.18-3178941-metrocustom-referenced_entities_reindexing_fatal_error-D8.patch (Fix Content Entity Tracker in 1.18)
patch '-p1' --no-backup-if-mismatch -d 'web/modules/contrib/search_api' < '/var/www/html/patches/1.18-3178941-metrocustom-referenced_entities_reindexing_fatal_error-D8.patch'
patch: unrecognized option: d

BusyBox v1.30.1 (2019-06-12 17:51:55 UTC) multi-call binary.

Usage: patch [OPTIONS] [ORIGFILE [PATCHFILE]]

	-p N	Strip N leading components from file names
	-i DIFF	Read DIFF instead of stdin
	-R	Reverse patch
	-N	Ignore already applied patches
	-E	Remove output files if they become empty
	--dry-run	Don't actually change files

@DiegoPino DiegoPino self-assigned this Nov 11, 2020
@DiegoPino DiegoPino added bug Something isn't working enhancement New feature or request labels Nov 11, 2020
@giancarlobi
Copy link

@DiegoPino I checked wacz install on Ubuntu 18 and commands are ok, only a little discrepancy: I need to chmod +x setup.py before execute. I don't know if it also needed on docker install.

@DiegoPino
Copy link
Member Author

DiegoPino commented Nov 12, 2020 via email

@DiegoPino
Copy link
Member Author

@giancarlobi WACZ is still not ready but I'm fine with moving with it as it is. Question
https://github.com/esmero/archipelago-docker-images/blob/ISSUE-21/esmero-php-fpm/Dockerfile#L120
This line installs composer but not sure if it will get composer 2 or I need to do a composer self-update --2 afterwards

Was missing some dependencies (Typical Python) and now should be Ok.

This includes now composer 2,
Some pythong tools and dependencies and the actual real Patch binary
I also learned that Python is a beast and you can not clear dependencies. All gets installed. Why people use this? anyhow..

esmero/php-7.4-fpm:1.0.0-RC1 should be pushed soon. I want to see the final py-wacz release first!
@DiegoPino
Copy link
Member Author

@giancarlobi this is ready now. PHP 7.4.9, Composer 2, py-wacz, PHP apcu (to faster than light performance) and Cantaloupe 4.1.7

@DiegoPino
Copy link
Member Author

I will have to rebuild and push this container now that py-wacz is in 0.2 and I would love to add djvu tools to this too #23

@DiegoPino DiegoPino merged commit 99c9b54 into master Dec 3, 2020
@DiegoPino DiegoPino deleted the ISSUE-21 branch January 7, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants