ISSUE-208: Actions, new processing logic. EAD Sync Plugin and Ingest Sanity #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoPino
added
enhancement
|
@alliomeria update to show actions/allow action configurations + enqueuing. Wonderful magic |
Only used for Delete so far so ok to refactor. Will return an array keyed by UUID and CSVs if any in the value Also adds an extra check and error for a CSV that no longer exist
This will have a config but for testing i added a if (TRUE) {
So far only acts on delete. But will do magic. I promise @alliomeria
…of code and PUFFF... a lily transforms into a weee fish... beautiful magic @alliomeria
This will have a config but for testing i added a if (TRUE) {
So far only acts on delete. But will do magic. I promise @alliomeria
Also: @alliomeria trying a thing here. I will start making files (including LoD) private. Not sure yet if this will affect download/etc. So need to try. Reason is the new EAD Sync generates multiple CSVs for each EAD (top) and i need to have more security for those files (even if temporary) when generating them. Will test more tomorrow (Bc falling asleep)
The number of changes here are brutal (in effort and number) and it is not ready yet for testing. But i need to commit before it gets out of hands. More tomorrow AM (and explanation for a demo @alliomeria). Going to bed now.
Private text files are send directly to the browser ... which is annoying as hell. We want the file to be downloaded... not shown as HTML. That leads to user error and Browser encoding options changing the original format .... damn Drupal (Drupal you are acting so bad lately)
basically we can't sort/organize if we don't process on every step possible sy=ub operations. Given that a 'sync' op depends on 'ami_sync_op' column being one of ['create','delete','update']
also empty($fullvalue) treats '' as empty .. I added 3 panic lines there... NOT really needed. But hey... panic
Since A sync can create/update and delete .. should a Sync AMI set also show/process the Delete Processed ADOs (tab and form?) @alliomeria you are the boss. You tell me
DiegoPino
changed the title
This was referenced Dec 13, 2024
Also use $config['temp_store_id']; are prefix for the generated CSVs That way multiple runs of the same XML generate new CSVs
@alliomeria tested. Creates/updates/deletes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #208