Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove node:assert dependency #633

Merged
merged 1 commit into from
Sep 27, 2024
Merged

fix: Remove node:assert dependency #633

merged 1 commit into from
Sep 27, 2024

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Sep 26, 2024

Prerequisites checklist

What is the purpose of this pull request?

What changes did you make? (Give an overview)

Removed node:assert as a dependency in eslint-scope, replacing it with a custom assert function.

Related Issues

Fixes #625
Closes #626

Is there anything you'd like reviewers to focus on?

Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aladdin-add aladdin-add merged commit 433a89d into main Sep 27, 2024
11 checks passed
@aladdin-add aladdin-add deleted the scope-assert branch September 27, 2024 01:51
@github-actions github-actions bot mentioned this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Bug: eslint-scope requires assert
2 participants