Throttle api #184
Merged
Throttle api #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #184 +/- ##
==========================================
+ Coverage 74.78% 75.83% +1.04%
==========================================
Files 31 32 +1
Lines 1170 1200 +30
==========================================
+ Hits 875 910 +35
+ Misses 295 290 -5 ☔ View full report in Codecov by Sentry. |
NelsonVides
force-pushed
the
throttle_api
branch
4 times, most recently
from
176d6b9 to
5f883d9
Compare
DenysGonchar
reviewed
Jun 6, 2024
NelsonVides
force-pushed
the
throttle_api
branch
10 times, most recently
from
572f130 to
cbe472d
Compare
NelsonVides
force-pushed
the
throttle_api
branch
from
cbe472d to
0bacea3
Compare
NelsonVides
force-pushed
the
throttle_api
branch
from
0bacea3 to
53cc8f8
Compare
NelsonVides
force-pushed
the
throttle_api
branch
3 times, most recently
from
6fdad6c to
84bfb08
Compare
NelsonVides
force-pushed
the
throttle_api
branch
from
84bfb08 to
c16c3d6
Compare
| case {RatePerMinutePerProcess < NoOfProcesses, R} of | ||
| {true, 0} -> | ||
| Config = #{max_n => RatePerMinutePerProcess, | ||
| delay => DelayPerProcess + 1, |
There was a problem hiding this comment.
why 1 is added to delay but not max_n
There was a problem hiding this comment.
I really don't get this function
There was a problem hiding this comment.
Let me try to add some comments with explanations.
There was a problem hiding this comment.
Ok, I've added a property-based test to check that the aggregated delays given to all processes don't differ from the actually requested rate by more than 1%, and I cannot get it to pass 😱
Please have a look at throttle_SUITE:pool_config_property_tests/1 @DenysGonchar
Not only this simplifies how the gradual config is triggered, but it also makes the gradual config transparent to the controller: the controller just applies a new rate every so much time. This not just makes the controller much simpler, but also, makes it possible to give it rate changes that are not necessarily only linear, but that could have more interesting shapes.
NelsonVides
force-pushed
the
throttle_api
branch
6 times, most recently
from
d462b4c to
3141f00
Compare
NelsonVides
force-pushed
the
throttle_api
branch
4 times, most recently
from
5d7edbe to
671e25e
Compare
NelsonVides
force-pushed
the
throttle_api
branch
from
671e25e to
73f1e61
Compare
NelsonVides
force-pushed
the
throttle_api
branch
from
73f1e61 to
92ef315
Compare
DenysGonchar
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the API for throttle more friendly to use