Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for unix socket #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

MoreDelay
Copy link

Hey there,

recently my MPD client of choice ncmpcpp went into maintenance mode, so I was looking for some alternatives. This project looks promising, and I can also contribute as I know some Rust. I am using Linux and configured MPD to use a unix socket file. I basically added a thin wrapper around the Client datastructure so that it can listen on that too, if applicable. I also checked these changes with Windows as a target, so this should not break anything.

On the library side, you would need to add a specialization on UnixStream as well. I implemented that too, do you want me to make a PR over there too?

Kind regards.

@eshrh
Copy link
Owner

eshrh commented Sep 5, 2024

Hi, this looks great! Yes, it would help a lot if you also made the changes on the library side (my hope is that my fork of rust-mpd becomes something as many people as possible can depend on).

Thanks for checking this project out, everything is still very new and under development... please feel free to implement (mostly) anything you'd like or leave an issue for feature requests. We'll probably never get to ncmpcpp in terms of raw feature-set, but I think that might be a good thing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants