Support FreeBSD #48
Merged
Support FreeBSD #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
reviewed
Sep 25, 2024
| @@ -504,6 +504,13 @@ static void *load_library(const char *const libname) { | |||
| assert(0); | |||
| } | |||
|
|
|||
| #elif __FreeBSD__ | |||
|
|
|||
| // dlmopen is not supported, always use dlopen instead | |||
There was a problem hiding this comment.
I think dlmopen is a glibc-only thing?
There was a problem hiding this comment.
Yes, it doesn't exist on FreeBSD. There's a run-time option to choose between dlopen and dlmopen, and I'm ignoring this on FreeBSD.
There was a problem hiding this comment.
What I wanted to suggest is to allow dlmopen only on glibc, rather than excluding on all platforms that don't support it, since it's more of an exception rather than the norm.
There was a problem hiding this comment.
I'm not excluding any platforms. I'm ignoring the option so that FreeBSD unconditionally uses dlopen. The alternative would be to emit an error on FreeBSD, but that doesn't seem worth the trouble.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.