-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and improvements #62
Conversation
For now i think im happy with this stage, ive been using this branch for my own server that i play with friends and i did not found many issues, the ones i did were fixed. Im planning on adding mod support (automatic download and update) in the future, but that would be better in its own PR. Keeping this as an draft until #60 is merged. |
Reorder Dockerfile and remove unnecessary dependencies Move bash scripts to their own folder Add environment variables for PUID and PGID Refactor and move parameter compilation to its own script Refactor server launch script and remove unnecessary code
Using su causes issues with tini, because su creates a new process hierarchy tini cannot properly forward signals to its childs, causing the game server to not shutdown properly in some cases, using gosu fully fixes those issues
It being wrong didnt cause any issues but better to fix it anyway
Tried your branch and it fixed all the issues I was having trying to deploy on TrueNAS. |
Level element has been deprecated, removing it should still be compatible with older compose versions
I made the choice of not printing the logs lines with timestamps because it seemed unnecessary, it is already possible to get logs from docker with timestamps by using |
Also fixes the issue with seasons
Changed the build action to trigger on an new release in github. |
I just saw that the new line |
Oh, thats true, sorry |
PUID
andPGID
chown
777
(rwxrwxrwx)COPY
command to be executed afterapt-get
RUN
command so docker can use build cache for test buildsapt-get
that seemed unnecessary (More about this at the end)tzdata
, this adds the possibility to change the container timezone by using the ENVTZ=
( Will come in handy with Updated launch.sh with Discord integration #60 )entry.sh
Rewrittenusermod
groupmod
chown
STEAMAPPDIR
andSTEAMAPPDATADIR
steam
usersetup.sh
Is basically what the oldentry.sh
did but refactored, mostly to make it cleaner.launch.sh
RefactorDISCORD
ENV, now it only checks ifDISCORD_HOOK
ENV is not empty to send the webhook pushcurl
output, it will still output in case of an error, but for success it will not output anything tostdout
compile-parameters.sh
script now handles the argument compilation/build and should be ran withsource
logs
folderparams
logfile
Now, i know some code that i removed from
launch.sh
and some dependencies i removed fromDockerfile
were there to fix an issue with green obsidian wall around spawn, but after removing those i generated and tested 10+ different maps and never found any issue with those.In my tests i lowered the outer wall and walked until i reached the end of the map and didn't find a single issue, as for hardware, i was using an GCP VM without an GPU.
It is possible that this issue got fixed in some patch, and if its the case simply merging this PR would not be a good idea.
Please let me know what you think.
Fixes #42, Fixes #57, Fixes #53