Propagate signals to launch.sh and fully await shutdown #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fully completes the passing of docker shutdown signals to the game executable. (Completes #46) Prior to this, the signals were not being passed from
entry.sh
tolaunch.sh
. Another alternative is to merely sourceentry.sh
fromlaunch.sh
and makelaunch.sh
the actual dockerfile command.Also, after some testing, i noticed some lost progress when shutting down the world. Delaying the termination of xvfb by
wait
ing within the trap handler seemed to eliminate this problem for me.