Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for linux-musl-s390x target #572

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

uweigand
Copy link
Contributor

This implements the rest of #571, after the "cb" part (ericsink/cb#21) is merged.

@ericsink
Copy link
Owner

The current failure is because e_sqlite3mc (which is a very recent addition to the cb build system) is not being built for musl-s390x. I am not sure what it would take to address this, so for now I will just Cc @utelle

@uweigand
Copy link
Contributor Author

Looks like this seems to be the only change needed: ericsink/cb#22

@ericsink ericsink merged commit 643cb69 into ericsink:master Nov 15, 2023
1 check passed
@uweigand uweigand deleted the linux-musl-s390x branch November 15, 2023 21:24
@utelle
Copy link
Contributor

utelle commented Nov 15, 2023

The current failure is because e_sqlite3mc (which is a very recent addition to the cb build system) is not being built for musl-s390x. I am not sure what it would take to address this, so for now I will just Cc @utelle

Sorry for the late response. I was away from home. Obviously, the problem is not related to SQLite3 Multiple Ciphers itself, but to the build procedure in cb.cs. Maybe the build procedure could be improved by making the list of targets a global object, instead of defining it separately for each component (making it easy to forget to add new targets to all relevant lists). This would allow to change it for all components in sync.

@ericsink
Copy link
Owner

No worries. It turned out to be an easy fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants