-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check inferred type against ascription in variable declaration #935
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks far bigger than what it actually is because of the indentation change which I had to do as part of doing the type validation at the end.
I've highlighted the main logical changes as comments. Rest is just indentation.
@aslesarenko @kushti Please review. |
@megatron00999 please rollback indentation so that I can review and analyze the changes. Then once approved, you can add identation back as separate commit. |
@aslesarenko Done, please take a look. |
@megatron00999, please look at the failing tests. |
Fixes #915
Code such as below now throws
UnexpectedType
exception.