Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation: Added support for typing.Type #41

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Validation: Added support for typing.Type #41

merged 2 commits into from
Sep 22, 2023

Conversation

erezsh
Copy link
Owner

@erezsh erezsh commented Sep 22, 2023

No description provided.

Copy link

@prplex prplex bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. Posted 1 comment.

# TODO test issubclass on t.__args__
return PythonDataType(type)
return Type
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that changing from returning 'PythonDataType(type)' to simply 'Type' doesn't unintentionally alter the program's behavior.

@erezsh erezsh merged commit fa15cd9 into master Sep 22, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant