Merge pull request #46 from erezsh/dev

types: fix for tuple <= sequence
erezsh · Nov 14, 2023 · 5bea984 · 5bea984
2 parents 6ec7b0e + 85834ec
commit 5bea984
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/runtype/base_types.py b/runtype/base_types.py
@@ -208,7 +208,7 @@ def __eq__(self, other):
 
 
     def __le__(self, other):
-        if isinstance(other, type(self)):
+        if isinstance(other, GenericType):
             return self.base <= other.base and self.item <= other.item
 
         elif isinstance(other, DataType):

diff --git a/tests/test_basic.py b/tests/test_basic.py
@@ -144,6 +144,9 @@ def test_tuple_ellipsis(self):
         assert_isa((1,2,3), Tuple[int, ...])
         self.assertRaises(TypeError, assert_isa, (1, "2"), Tuple[int, ...])
 
+        assert issubclass(Tuple[str, ...], typing.Sequence[str])
+        assert not issubclass(Tuple[str, ...], typing.Sequence[int])
+
     @unittest.skipIf(sys.version_info < (3, 8), "Not supported before Python 3.8")
     def test_py38(self):
         assert isa('a', typing.Literal['a', 'b'])