tests: change how pytest adds markers #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soofstad
reviewed
Sep 4, 2024
mariuswinger
force-pushed
the
tests/fix-conftest-pytest-marks
branch
from
24f6d65
to
da71ffd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this pull request needed?
The old setup didn't work particularly well/was buggy.
What does this pull request change?
Markers are automatically added based on the parent test directory.
pytest --unitandpytestruns unit tests, whilepytest --integrationruns integration tests. Finally,pytest --unit --integrationruns both. Furthermore, one can use markers to select the appropriate tests even quicker: e.g.pytest -m integration, which skips collecting all tests and just collects integration tests.Also, pre-commit was failing on main, so I had to make some additional changes in order to make it run successfully. The state of this repo right now ...
Issues related to this change:
None.