Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/biome #242

Merged
merged 4 commits into from
Jun 6, 2024
Merged

Feat/biome #242

merged 4 commits into from
Jun 6, 2024

Conversation

soofstad
Copy link
Collaborator

@soofstad soofstad commented Jun 5, 2024

Remove old Yarn2(PnP) stuff

Replaces eslint and prettier with biome

Remove black, as ruff does the same and more.
Change ruff pre-commit hook to official repo.

@soofstad soofstad self-assigned this Jun 5, 2024
@soofstad soofstad requested a review from a team as a code owner June 5, 2024 08:49
@sebastianvitterso
Copy link
Contributor

image

My guess is that you need to use a newer node image for the runner, or use the actions/setup-node@v4 action.

Copy link
Contributor

@sebastianvitterso sebastianvitterso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would prefer double JSX-quotes, but otherwise I agree with the changes!

web/src/App.tsx Outdated Show resolved Hide resolved
web/biome.json Outdated Show resolved Hide resolved
Copy link
Contributor

@sebastianvitterso sebastianvitterso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

web/Dockerfile Outdated Show resolved Hide resolved
@soofstad soofstad merged commit 337ed61 into main Jun 6, 2024
7 checks passed
@soofstad soofstad deleted the feat/biome branch June 6, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants