fix batch status incorrectly transitioning to Waiting #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s temporary empty ready count
satr
approved these changes
Oct 17, 2024
1 task
nilsgstrabo
deleted the
bugfix-batchjob-condition-transitions-back-to-waiting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A RadixBatch will temporary transition from Active to Waiting when the Pod is finished (success or failed) in which k8s Job has status.active unset. To fix this we will reuse the last know RadixBatchJobStatus.Phas for the job instead of defaulting to BatchJobPhaseWaiting.
This change will also inspect the k8s job's Status.UncountedTerminatedPods to transtition to completed or failed faster, and thereby preventing on unnecessary update of RadixBatch status, which will trigger an unnecessary informer event to the job scheduler webhook.