Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create scaling objects instead of hpa #1116

Merged
merged 31 commits into from
May 16, 2024
Merged

Create scaling objects instead of hpa #1116

merged 31 commits into from
May 16, 2024

Conversation

Richard87
Copy link
Contributor

No description provided.

@Richard87 Richard87 self-assigned this May 10, 2024
@Richard87 Richard87 mentioned this pull request May 10, 2024
Closed
22 tasks
nilsgstrabo
nilsgstrabo requested changes May 15, 2024
View reviewed changes
Copy link
Contributor

@nilsgstrabo nilsgstrabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions and comments.
We must also add ScaledObject to the radix-operator clusterrole (all verbs), and to the radix-api and radix-app-admin-envs clusterroles (get, list, watch) if radix-api needs to read the ScaledObject.

pkg/apis/utils/init.go Outdated Show resolved Hide resolved
pkg/apis/utils/scaler.go Outdated Show resolved Hide resolved
pkg/apis/radixvalidators/validate_ra_test.go Outdated Show resolved Hide resolved
pkg/apis/radixvalidators/validate_ra_test.go Outdated Show resolved Hide resolved
pkg/apis/radixvalidators/validate_ra_test.go Outdated Show resolved Hide resolved
pkg/apis/radixvalidators/validate_ra_test.go Outdated Show resolved Hide resolved
pkg/apis/deployment/kubedeployment.go Outdated Show resolved Hide resolved
pkg/apis/deployment/deployment.go Outdated Show resolved Hide resolved
pkg/apis/deployment/scaledobject.go Show resolved Hide resolved
pkg/apis/deployment/scaledobject.go Show resolved Hide resolved
@Richard87
Copy link
Contributor Author

Added some suggestions and comments. We must also add ScaledObject to the radix-operator clusterrole (all verbs), and to the radix-api and radix-app-admin-envs clusterroles (get, list, watch) if radix-api needs to read the ScaledObject.

Fixed, added get,list,watch to app admins and app readers (in -envs cluster roles), and get,list,create,update,patch,delete,watch to Radix Operator

@Richard87 Richard87 merged commit 70b52cf into master May 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsgstrabo nilsgstrabo nilsgstrabo approved these changes

Assignees

@Richard87 Richard87

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Richard87 @nilsgstrabo