Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom scaling triggers #1112

Merged
merged 73 commits into from
May 30, 2024
Merged

Custom scaling triggers #1112

merged 73 commits into from
May 30, 2024

Conversation

Richard87
Copy link
Contributor

No description provided.

@Richard87 Richard87 self-assigned this May 8, 2024
@Richard87 Richard87 mentioned this pull request May 8, 2024
Closed
22 tasks
@Richard87 Richard87 changed the title Keda Feature Custom scaling triggers May 8, 2024
@Richard87
Create ScaledObjects instead of HPAs
eed35a3
@Richard87
fix dependencies
44a08ad
@Richard87
Merge branch 'refs/heads/master' into create-scaling-objects-instead-…
3d9835d 
…of-hpa
@Richard87
update mocks and test infrastructure with new kedaClient
9697649
@Richard87
fail tests instead of panicks
32f59c2
@Richard87
change test to verify ScaledObjects instead of HPAs
27f6959
@Richard87
remove legacy code
90b9738
@Richard87
revert gomod change
7237aa7
@Richard87
fix bugi n makefile
5fe72a4
@Richard87
move kedaclient to kubeutil
4aa7659
@Richard87
refactor validation, add more details to tests, configure default min…
ba8c465 
…Replicas
@Richard87
refactor validation, add more details to tests, configure default min…
b9275a5 
…Replicas
@Richard87
cleanup naming
2099cd9
@Richard87
retain keda label
75f4c27
@Richard87
use json-patch v5
bac3d0a
@Richard87
use threeway patch
c405532
@Richard87
update gomod
e2201e3
@Richard87
rename default target
3891ca9
@Richard87
Update CRD with new horizontal scaling triggers
249f3a2
nilsgstrabo
nilsgstrabo requested changes May 27, 2024
View reviewed changes
Copy link
Contributor

@nilsgstrabo nilsgstrabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggestions

@Richard87 Richard87 merged commit fbbdef5 into master May 30, 2024
12 checks passed
@Richard87 Richard87 deleted the replace-hpa-with-keda branch May 30, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsgstrabo nilsgstrabo nilsgstrabo approved these changes

Assignees

@Richard87 Richard87

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Richard87 @nilsgstrabo