Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pipeline job deployment race condition #1073

Merged
merged 14 commits into from
Mar 22, 2024

Conversation

satr
Copy link
Contributor

@satr satr commented Mar 21, 2024

No description provided.

@satr satr self-assigned this Mar 21, 2024
@satr satr requested a review from nilsgstrabo March 21, 2024 16:14
Copy link
Contributor

@nilsgstrabo nilsgstrabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Added a few suggestions to the log messages. If you don't agree, then just keep yours
  • Add tests in deploy_test.go to test that the error returned by RadixDeploymentWatcher is handled correctly

pipeline-runner/steps/deploy.go Outdated Show resolved Hide resolved
pipeline-runner/steps/deploy.go Outdated Show resolved Hide resolved
pipeline-runner/steps/deploy.go Outdated Show resolved Hide resolved
pipeline-runner/steps/deploy.go Outdated Show resolved Hide resolved
pipeline-runner/steps/deploy.go Outdated Show resolved Hide resolved
pkg/apis/kube/deployment.go Outdated Show resolved Hide resolved
pkg/apis/kube/deployment.go Outdated Show resolved Hide resolved
@satr satr merged commit 2884277 into master Mar 22, 2024
6 checks passed
@satr satr deleted the fix-pipeline-job-deployment-race-condition branch March 22, 2024 12:11
satr added a commit that referenced this pull request Mar 25, 2024
Fix pipeline job deployment race condition (#1073)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants