Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1120 read only file system #1049

Merged
merged 27 commits into from
Feb 23, 2024
Merged

1120 read only file system #1049

merged 27 commits into from
Feb 23, 2024

Conversation

nilsgstrabo
Copy link
Contributor

No description provided.

@nilsgstrabo nilsgstrabo self-assigned this Feb 7, 2024
@nilsgstrabo nilsgstrabo linked an issue Feb 7, 2024 that may be closed by this pull request
Immutable (read-only) root filesystem should be enforced for containers equinor/radix-platform#1120
Closed
8 tasks
@anneliawa anneliawa marked this pull request as ready for review February 16, 2024 10:00
Richard87
Richard87 requested changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@Richard87 Richard87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some test coments

pkg/apis/deployment/radixcomponent_test.go Outdated Show resolved Hide resolved
pkg/apis/deployment/radixjobcomponent_test.go Outdated Show resolved Hide resolved
Richard87
Richard87 previously approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@Richard87 Richard87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Godkjent

Richard87
Richard87 approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@Richard87 Richard87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Godkjent! :D

@anneliawa anneliawa merged commit c953b38 into master Feb 23, 2024
6 checks passed
@anneliawa anneliawa deleted the 1120-readOnlyFileSystem branch February 23, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anneliawa anneliawa anneliawa left review comments

@Richard87 Richard87 Richard87 approved these changes

Assignees

@nilsgstrabo nilsgstrabo

@anneliawa anneliawa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Immutable (read-only) root filesystem should be enforced for containers
3 participants
@nilsgstrabo @Richard87 @anneliawa