Retain external dns secret on component change #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved creation of external DNS TLS secrets and certificates out of the "sync component" code branch.
The certificate is now created explicitly instead of implicitly via Ingress annotations.
The certs and secrets are no longer labelled with the component name, but with the FQDN instead, and garbage collection of a component will therefore no longer delete external DNS certs and secrets. External DNS has its own garbage collection routine.
Tested with a full sync of secrets and certs restored from eu-18, and all secrets were successfully relabelled and no data was lost.