-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concurrency implementation using batch processor #106
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7d1d1fc
Refactor to use ecl2df for summary file extraction
berland 9830f63
Move to datetime64 indexed dataframes
berland 211c3f2
Concurrency implementation of fmu-ensemble using concurrent.futures
berland 07c068c
Avoid eclsum caching, causes segfaults
berland File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,6 +22,7 @@ | |
|
||
REQUIREMENTS = [ | ||
"ecl>=2.9", | ||
"ecl2df", | ||
"numpy", | ||
"pandas", | ||
"pyyaml>=5.1", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
"""Common functions for fmu.ensemble""" | ||
|
||
import os | ||
import logging | ||
|
||
logger = logging.getLogger(__name__) | ||
|
||
ENV_NAME = "FMU_CONCURRENCY" | ||
|
||
|
||
def use_concurrent(): | ||
"""Determine whether we should use concurrency or not | ||
|
||
This is based on both an environment variable | ||
and presence of concurrent.futures, and on Python version | ||
|
||
Returns: | ||
bool: True if concurrency mode should be used | ||
""" | ||
if ENV_NAME not in os.environ: | ||
return True | ||
env_var = os.environ[ENV_NAME] | ||
if ( | ||
str(env_var) == "0" | ||
or str(env_var).lower() == "false" | ||
or str(env_var).lower() == "no" | ||
): | ||
return False | ||
return True | ||
|
||
|
||
def set_concurrent(concurrent): | ||
"""Set the concurrency mode used by fmu.ensemble. | ||
|
||
This is done through modifying the enviroment variable | ||
for the current Python process | ||
|
||
If concurrency is asked for by but not possible, a warning | ||
will be printed and the code will continue in sequential mode. | ||
|
||
Args: | ||
concurrent (bool): Set to True if concurrent mode is requested, | ||
False if not. | ||
""" | ||
if isinstance(concurrent, bool): | ||
os.environ[ENV_NAME] = str(concurrent) | ||
else: | ||
raise TypeError | ||
# Check for success: | ||
if concurrent and not use_concurrent(): | ||
logger.warning("Unable to activate concurrent code") |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this looks better and reduces the usage of
str(..)
andlower()
?