Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve consistency of tests by removing InitDb in tests #1766

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Improve consistency of tests by removing InitDb in tests #1766

merged 1 commit into from
Oct 21, 2024

Conversation

Christdej
Copy link
Contributor

@Christdej Christdej commented Oct 15, 2024 •
edited
Loading

Also change to short-way of initializing lists

@Christdej Christdej added the improvement Improvement to existing functionality label Oct 15, 2024
@Christdej Christdej self-assigned this Oct 15, 2024
@github-actions GitHub Actions
Copy link

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@Christdej Christdej force-pushed the initdbconfig branch 4 times, most recently from 4df46c0 to 77ff664 Compare October 16, 2024 10:49
@Christdej Christdej marked this pull request as ready for review October 16, 2024 10:52
andchiind
andchiind approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise

backend/api.test/Client/AreaTests.cs Show resolved Hide resolved
backend/api.test/Client/MissionTests.cs Show resolved Hide resolved
backend/api.test/Database/DatabaseUtilities.cs Show resolved Hide resolved
backend/api.test/EventHandlers/TestMissionEventHandler.cs Show resolved Hide resolved
backend/api.test/Services/RobotService.cs Outdated Show resolved Hide resolved
This was linked to issues Oct 21, 2024
MissionIsCreatedInArea test is nondeterministic #1686
Closed
Stop using InitDb in tests #1687
Closed
@Christdej Christdej merged commit 5b11d42 into equinor:main Oct 21, 2024
11 checks passed
@Christdej Christdej deleted the initdbconfig branch October 21, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andchiind andchiind andchiind approved these changes

Assignees

@Christdej Christdej

Labels
improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop using InitDb in tests MissionIsCreatedInArea test is nondeterministic
2 participants
@Christdej @andchiind