Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forward model output functionality #76

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DanSava
Copy link
Collaborator

@DanSava DanSava commented Oct 31, 2024

Resolves: equinor/ert#8757

@DanSava DanSava force-pushed the add_objective_validation_functionality branch from cb8a768 to f4251d1 Compare November 4, 2024 11:38
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 70.21277% with 14 lines in your changes missing coverage. Please review.

Project coverage is 87.45%. Comparing base (974266c) to head (f4251d1).

Files with missing lines Patch % Lines
src/everest_models/everest_hooks.py 18.75% 13 Missing ⚠️
.../everest_models/jobs/fm_well_constraints/parser.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   87.79%   87.45%   -0.34%     
==========================================
  Files         133      133              
  Lines        3350     3373      +23     
==========================================
+ Hits         2941     2950       +9     
- Misses        409      423      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@StephanDeHoop StephanDeHoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just two minor questions/comments

tests/jobs/npv/test_npv_cli.py Show resolved Hide resolved
@DanSava DanSava self-assigned this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try to validate that objectives are correctly specified
3 participants