Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the output section from the well trajectory config #29

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

verveerpj
Copy link
Contributor

The PR removes the output section from the configuration of the well trajectory forward model. That section gave the user too many unnecessary options to determine which output files were written and what names these should have. Now the set of output files and their names are standardized.

The npv_input field from output sections has been moved the main configuration and renamed npv_input_file. This conveys a bit better that this is actually not a pure output, but an existing input file for another job that should be modified by the forward model.

@verveerpj verveerpj self-assigned this Jul 4, 2024
@verveerpj verveerpj force-pushed the well-trajectory-config-changes branch from 351e87a to 0909900 Compare July 4, 2024 12:21
@verveerpj verveerpj marked this pull request as draft July 4, 2024 12:22
@verveerpj verveerpj force-pushed the well-trajectory-config-changes branch from 0909900 to d2180a3 Compare July 4, 2024 14:06
@verveerpj verveerpj marked this pull request as ready for review July 4, 2024 14:07
Copy link
Collaborator

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@verveerpj verveerpj merged commit c0336e6 into main Jul 6, 2024
11 checks passed
@verveerpj verveerpj deleted the well-trajectory-config-changes branch July 6, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants