Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Well swapping #2

Merged
merged 3 commits into from
May 27, 2024
Merged

Well swapping #2

merged 3 commits into from
May 27, 2024

Conversation

sregales-TNO
Copy link
Contributor

@sregales-TNO sregales-TNO commented May 5, 2024

A new iterative forward model that switches well operation states based on well priorities and operation viability over time.

Copy link
Collaborator

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I guess you plan to fix some todos but overall looks good.

- Reduce the amount of forward models call (for each iteration)
  - drill_planner
  - adjust_well_status
  - track_well_switch
  - update_dates
  - add_templates
- Reduce the amount of IO calls (intermittent files)
- Faster workflow
- manage operation state and actions with a state machine
There has been talks of making this project into a library
and letting each forward model creator manage there own forward model.
For this we need a prorper and clear standard that each project can inherit and abide by.

What better way then starting with the parser standard.
New parser standard:
- uses three main cammands, run, lint, and schema
- retains backwards compatibility with old adhoc version
- library is plug-n-play
Copy link
Collaborator

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice one

@sregales-TNO sregales-TNO merged commit e728d5a into main May 27, 2024
6 of 8 checks passed
@sregales-TNO sregales-TNO deleted the well-swapping branch May 27, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants