Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the use of EverestConfig in function signatures in everest csv exporting #9163

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DanSava
Copy link
Contributor

@DanSava DanSava commented Nov 6, 2024

Issue
Resolves #9162

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@DanSava DanSava self-assigned this Nov 6, 2024
@DanSava DanSava force-pushed the export-refactor-usage-of-everest-config-in-function-signature branch 2 times, most recently from c1ad78a to 3b16502 Compare November 6, 2024 12:42
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (4b18368) to head (2622c1b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9163      +/-   ##
==========================================
- Coverage   90.76%   90.75%   -0.01%     
==========================================
  Files         351      351              
  Lines       21901    21903       +2     
==========================================
  Hits        19879    19879              
- Misses       2022     2024       +2     
Flag Coverage Δ
cli-tests 39.25% <ø> (+0.01%) ⬆️
gui-tests 71.74% <ø> (-0.01%) ⬇️
performance-tests 49.39% <ø> (+<0.01%) ⬆️
unit-tests 79.64% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanSava DanSava force-pushed the export-refactor-usage-of-everest-config-in-function-signature branch 2 times, most recently from 8c90bf0 to b995073 Compare November 7, 2024 10:53
@DanSava DanSava force-pushed the export-refactor-usage-of-everest-config-in-function-signature branch from b995073 to 2622c1b Compare November 7, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit the use of EverestConfig everest export
2 participants