Smaller simplifications of everest baserunmodel #9158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9158 +/- ##
==========================================
- Coverage 90.75% 90.75% -0.01%
==========================================
Files 351 351
Lines 21901 21903 +2
==========================================
Hits 19877 19877
- Misses 2024 2026 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yngve-sk
force-pushed
the
24.11.05.simplify-everest-baserunmodel
branch
2 times, most recently
from
6e27ae1
to
4f7f6e1
Compare
yngve-sk
force-pushed
the
24.11.05.simplify-everest-baserunmodel
branch
from
4f7f6e1
to
d5f9a80
Compare
StephanDeHoop
approved these changes
Nov 5, 2024
| optimizer = self._configure_optimizer(simulator) | ||
|
|
||
| # Before each batch evaluation we check if we should abort: | ||
| optimizer.add_observer( |
There was a problem hiding this comment.
So functionally the only difference is that now we add an observer when we create the optimizer (at the end) instead of outside that method?
There was a problem hiding this comment.
Yep. It was always created after initializing, just not within that function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.