Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pytest option typo #9141

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

HakonSohoel
Copy link
Contributor

@HakonSohoel HakonSohoel commented Nov 4, 2024

Issue
Resolves #9140

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@HakonSohoel HakonSohoel added the release-notes:skip If there should be no mention of this in release notes label Nov 4, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (8c679c1) to head (136fcea).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9141      +/-   ##
==========================================
- Coverage   90.78%   90.75%   -0.03%     
==========================================
  Files         351      351              
  Lines       21889    21889              
==========================================
- Hits        19871    19865       -6     
- Misses       2018     2024       +6     
Flag Coverage Δ
cli-tests 39.23% <ø> (+<0.01%) ⬆️
gui-tests 71.79% <ø> (ø)
performance-tests 49.41% <ø> (+<0.01%) ⬆️
unit-tests 79.65% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@HakonSohoel HakonSohoel removed the request for review from oyvindeide November 5, 2024 11:18
@HakonSohoel HakonSohoel merged commit 59453cf into equinor:main Nov 5, 2024
56 checks passed
@HakonSohoel HakonSohoel deleted the fix-test-marker-typo branch November 5, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix pytest option typo
3 participants