Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate flakiness in memory profiling #9132

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

berland
Copy link
Contributor

@berland berland commented Nov 1, 2024

And add some explanation to aid future.

Issue
Resolves #9101

Approach
we try harder

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

And add some explanation for further debugging
@berland berland self-assigned this Nov 1, 2024
@berland berland added the release-notes:flaky-test-fix PR fixes a flaky test label Nov 1, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (044db5a) to head (3424398).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9132      +/-   ##
==========================================
+ Coverage   90.74%   90.75%   +0.01%     
==========================================
  Files         350      350              
  Lines       21800    21800              
==========================================
+ Hits        19782    19785       +3     
+ Misses       2018     2015       -3     
Flag Coverage Δ
cli-tests 39.03% <ø> (+0.01%) ⬆️
gui-tests 71.71% <ø> (+0.02%) ⬆️
performance-tests 49.29% <ø> (+0.01%) ⬆️
unit-tests 79.61% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berland berland enabled auto-merge (rebase) November 1, 2024 12:23
@berland berland merged commit 7ee89c1 into equinor:main Nov 1, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:flaky-test-fix PR fixes a flaky test
Projects
Status: Done
3 participants