Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend save parameters to handle multiple realizations #9125

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Nov 1, 2024

Add test that uses the new functionality and also documents some troublesome behavior of adaptive localization.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@dafeda dafeda self-assigned this Nov 1, 2024
@dafeda dafeda added the release-notes:improvement Automatically categorise as improvement in release notes label Nov 1, 2024
@@ -210,3 +217,112 @@ def test_parameter_update_with_inactive_cells_xtgeo_grdecl(tmpdir):
assert "nan" not in Path(
"simulations/realization-0/iter-1/my_param.grdecl"
).read_text(encoding="utf-8")


def test_field_param_update_using_heat_equation__zero_var_params_and_adaptive_loc(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extra underscore __zero

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks.

@dafeda dafeda force-pushed the save-parameters-sequence branch 2 times, most recently from 4a8f565 to 219b545 Compare November 6, 2024 08:18
Add test that uses the new functionality and also documents
some troublesome behavior of adaptive localization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

2 participants