Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging of step runtime statistics #9121

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

berland
Copy link
Contributor

@berland berland commented Oct 31, 2024

This had to be moved to _ensemble.py as the state inside _snapshot.py only had information about steps that fell into the same batching window, thus long lasting steps would have start_time=None

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland force-pushed the fixup_step_logging branch 2 times, most recently from b5eb5b7 to 6546da8 Compare October 31, 2024 16:46
@berland berland requested a review from sondreso October 31, 2024 16:48
This had to be moved to _ensemble.py as the state inside _snapshot.py
only had information about steps that fell into the same batching
window, thus long lasting steps would have start_time=None
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.72%. Comparing base (c077aad) to head (d415f44).

Files with missing lines Patch % Lines
src/ert/ensemble_evaluator/_ensemble.py 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9121      +/-   ##
==========================================
- Coverage   90.73%   90.72%   -0.02%     
==========================================
  Files         350      350              
  Lines       21781    21787       +6     
==========================================
+ Hits        19764    19766       +2     
- Misses       2017     2021       +4     
Flag Coverage Δ
cli-tests 39.03% <87.50%> (-0.01%) ⬇️
gui-tests 71.70% <87.50%> (+0.01%) ⬆️
performance-tests 49.24% <81.25%> (+<0.01%) ⬆️
unit-tests 79.58% <87.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try again 🚀

@berland berland merged commit 8c312f2 into equinor:main Nov 1, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants