Fix flaky debug info button test and change button text #9117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-eq
added
release-notes:improvement
…data_in_clipboard The test is flaky because it is assuming the experiment will be done in 10s, which is not always the case. The button is regardless independent of the experiment status, so this check is not neccessary. The QueueEmitter gets corrupted if we leave the experiment hanging when cleaning up the test, so we have to cancel it before leaving.
The button text was misleading, as it could be interpreted as "show debug info" instead of it copying the debug info to the clipboard.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9117 +/- ##
==========================================
+ Coverage 90.69% 90.72% +0.03%
==========================================
Files 349 350 +1
Lines 21764 21778 +14
==========================================
+ Hits 19738 19758 +20
+ Misses 2026 2020 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jonathan-eq
force-pushed
the
fix-more-flaky-test
branch
from
f206ad6
to
2fb3fee
Compare
andreas-el
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #9115
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable