Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace interface towards eclrun and flow using fmstep_config #9108

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

berland
Copy link
Contributor

@berland berland commented Oct 31, 2024

Issue
Resolves #8925

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland marked this pull request as draft October 31, 2024 08:20
@berland berland self-assigned this Oct 31, 2024
General configuration using key-values via the plugin system for
individual steps will be merged with environment property of each
ForwardModelStep that is dumped as json in every runpath.
wip: simplified EclRun

wip: can run eclipse on flow_example

wip: eclipse maybe works, flowrun missing

Renamed files, merging eclrun and flowrun now

Merged runner script for flowrun and eclrun

more opm flowrun tests in place

Allow usage of direct flow installation if no flowrun

No MPI run without flowrun

fixup, test_await needs to u se tmp_dir fixture

Can't test eclipse version when no elcrun. UNTESTED

fixup d3ee82b127410fea173d7e914dd80dfb5132831e2

wip: dedicated test_run_reservoirsimultor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up EclRun
1 participant