Remove iEverest #9097
Merged
Remove iEverest #9097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frode-aarstad
added
the
release-notes:breaking-change
frode-aarstad
force-pushed
the
remove-everest-gui
branch
from
8b7ebae
to
65d92fc
Compare
verveerpj
approved these changes
Oct 31, 2024
ci/testkomodo.sh
Outdated
| -m "not requires_eclipse and not ui_test" | ||
| xvfb-run -s "-screen 0 640x480x24" --auto-servernum python -m pytest tests/everest -s -m "ui_test" | ||
| -m "not requires_eclipse" | ||
| xvfb-run -s "-screen 0 640x480x24" --auto-servernum python -m pytest tests/everest -s |
There was a problem hiding this comment.
Is the xvfb still needed?
There was a problem hiding this comment.
It should not be needed no. Will try and remove
src/everest/bin/main.py
Outdated
| ieverest_entry(args) | ||
| """Start the graphical user interface (Deprecated)""" | ||
| print( | ||
| "The gui command has been deprecated. Please use the run command instead." |
There was a problem hiding this comment.
It's not really deprecated, right? It is removed.
There was a problem hiding this comment.
You are correct. I will change the text
frode-aarstad
force-pushed
the
remove-everest-gui
branch
from
95691cb
to
602a4f5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9097 +/- ##
==========================================
- Coverage 90.72% 90.67% -0.06%
==========================================
Files 350 350
Lines 21783 21783
==========================================
- Hits 19763 19752 -11
- Misses 2020 2031 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #8907
Approach
🔪
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable