Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use maxprocesses=2 for cli tests #9089

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

JHolba
Copy link
Contributor

@JHolba JHolba commented Oct 30, 2024

Lowering the amount of processes used for cli tests to see if it helps flaky ensemble evaluator

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@JHolba JHolba added the release-notes:flaky-test-fix PR fixes a flaky test label Oct 30, 2024
@JHolba JHolba self-assigned this Oct 30, 2024
Lowering from -n logical to auto for cli tests to see if it helps flaky
ensemble evaluator
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eivindjahren eivindjahren enabled auto-merge (rebase) October 30, 2024 08:46
@JHolba JHolba disabled auto-merge October 30, 2024 10:11
@eivindjahren eivindjahren changed the title Use -n auto for cli tests Use maxprocesses=2 for cli tests Oct 30, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.71%. Comparing base (ca68c84) to head (fe1ede3).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9089      +/-   ##
==========================================
+ Coverage   90.68%   90.71%   +0.02%     
==========================================
  Files         350      350              
  Lines       21778    21778              
==========================================
+ Hits        19750    19756       +6     
+ Misses       2028     2022       -6     
Flag Coverage Δ
cli-tests 39.03% <ø> (+<0.01%) ⬆️
gui-tests 71.71% <ø> (+0.02%) ⬆️
performance-tests 49.24% <ø> (ø)
unit-tests 79.56% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eivindjahren eivindjahren merged commit 66aa073 into equinor:main Nov 1, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:flaky-test-fix PR fixes a flaky test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants