Make plot_api return all observations for response #9087
Conversation
yngve-sk
force-pushed
the
bugfix-few-observations-rendered
branch
from
9ac354a
to
aaefcbb
Compare
yngve-sk
changed the title
yngve-sk
added
the
release-notes:bug-fix
src/ert/gui/tools/plot/plot_api.py
Outdated
|
|
||
| observations = response.json() | ||
| observations_dfs = [] | ||
|
|
||
| if not response.json(): |
There was a problem hiding this comment.
Why not replace if not response.json(): with if not observations: if you already declared observations = response.json() on ln 209
src/ert/gui/tools/plot/plot_api.py
Outdated
| if not response.json(): | ||
| continue | ||
| try: | ||
| obs = response.json()[0] | ||
| response.json()[0] |
There was a problem hiding this comment.
Similar why not replace response.json()[0] with observations[0]
src/ert/gui/tools/plot/plot_api.py
Outdated
| try: | ||
| obs = response.json()[0] | ||
| response.json()[0] | ||
| except (KeyError, IndexError, JSONDecodeError) as e: | ||
| raise httpx.RequestError( | ||
| f"Observation schema might have changed key={key}, ensemble_name={ensemble.name}, e={e}" | ||
| ) from e |
There was a problem hiding this comment.
It is unclear to me what the purpose of this section is now.
There was a problem hiding this comment.
I'm not sure either, but am also not confident to just remove it here as part of this bugfix, although I think this entire module, PlotAPI/Dark storage could be simplified alot
There was a problem hiding this comment.
I agree with keeping it for now
yngve-sk
force-pushed
the
bugfix-few-observations-rendered
branch
from
1a724db
to
3a852ef
Compare
yngve-sk
force-pushed
the
bugfix-few-observations-rendered
branch
from
3a852ef
to
781d473
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9087 +/- ##
=======================================
Coverage 90.75% 90.75%
=======================================
Files 350 350
Lines 21778 21781 +3
=======================================
+ Hits 19764 19767 +3
Misses 2014 2014
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Issue
Resolves #9077
Tested on RGS for stable and bleeding:
Before (left is rendering only one instead of 3 observations):
After: