Add default values using Pandas assign in design_matrix #8949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsevj
added
the
release-notes:unreleased-feature-changes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8949 +/- ##
==========================================
- Coverage 90.76% 90.73% -0.04%
==========================================
Files 351 351
Lines 21895 21893 -2
==========================================
- Hits 19874 19864 -10
- Misses 2021 2029 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xjules
reviewed
Oct 11, 2024
src/ert/config/design_matrix.py
Outdated
|
|
||
| Returns a dict of default values | ||
| Returns a dict of usable default values |
larsevj
force-pushed
the
insert_new_columns_all_at_once
branch
from
383f774
to
fe5cc7e
Compare
xjules
reviewed
Oct 25, 2024
| return { | ||
| row[0]: convert_to_numeric(row[1]) | ||
| for _, row in default_df.iterrows() | ||
| if row[0] not in existing_parameters |
There was a problem hiding this comment.
Shall we write a test for this?
larsevj
force-pushed
the
insert_new_columns_all_at_once
branch
from
fe5cc7e
to
8dc3ba3
Compare
larsevj
force-pushed
the
insert_new_columns_all_at_once
branch
from
8dc3ba3
to
2a49444
Compare
xjules
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve Pandas performance warning
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable