Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checks for storage_server.json in storage #8939

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JHolba
Copy link
Contributor

@JHolba JHolba commented Oct 10, 2024

We no longer use this file for connection info.
Seems to be leftovers from earlier code.

Issue
Resolves #8452

Approach
remove all use of storage_server.json

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.80%. Comparing base (b9cfd46) to head (fccf325).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8939      +/-   ##
==========================================
+ Coverage   91.65%   91.80%   +0.14%     
==========================================
  Files         343      343              
  Lines       21149    21201      +52     
==========================================
+ Hits        19385    19463      +78     
+ Misses       1764     1738      -26     
Flag Coverage Δ
cli-tests 39.81% <100.00%> (-0.02%) ⬇️
gui-tests 73.73% <100.00%> (-0.12%) ⬇️
performance-tests 50.40% <100.00%> (-0.05%) ⬇️
unit-tests 80.45% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JHolba JHolba self-assigned this Oct 11, 2024
We no longer use this file for connection info.
Seems to be leftovers from earlier code.
@JHolba JHolba force-pushed the remove-storage-server-json-checks branch from bf01ab9 to fccf325 Compare October 11, 2024 08:14
@JHolba JHolba marked this pull request as ready for review October 11, 2024 08:19
@JHolba JHolba changed the title Remove code that checks for storage_server.json Remove checks for storage_server.json in storage Oct 11, 2024
@JHolba JHolba added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Oct 11, 2024
Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! ✂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage_server json inhibits ert from plotting after error encountered
3 participants