Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Added contentMaxHeight prop to Dialog #829

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Conversation

mariush2
Copy link
Contributor

@mariush2 mariush2 commented Oct 22, 2024

@mariush2 mariush2 requested a review from a team as a code owner October 22, 2024 05:44
Copy link

github-actions bot commented Oct 22, 2024

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 100% (🎯 100%) 11857 / 11857
🟢 Statements 100% (🎯 100%) 11857 / 11857
🟢 Functions 100% (🎯 100%) 547 / 547
🟢 Branches 100% (🎯 100%) 2458 / 2458
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/molecules/Dialog/Dialog.styles.ts 100% 100% 100% 100%
src/molecules/Dialog/Dialog.tsx 100% 100% 100% 100%
Generated in workflow #1070 for commit 89e2f64 by the Vitest Coverage Report Action

Copy link
Contributor

@aslakihle aslakihle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lil nitpick 😏

src/molecules/Dialog/Dialog.stories.tsx Outdated Show resolved Hide resolved
@mariush2
Copy link
Contributor Author

Included a version bump as well to get this out to the Premo team

@mariush2 mariush2 merged commit a58b6e0 into main Oct 22, 2024
10 checks passed
@mariush2 mariush2 deleted the feat/dialog-content-height branch October 22, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants