Skip to content

Commit

Permalink
fix(k8s): Deployment.strategy is independent of deploymentType
Browse files Browse the repository at this point in the history
When unset, k8s defaults are the following:

rollingUpdate:
  maxSurge: 25%
  maxUnavailable: 25%

Currently, the same values are set when deploymentType is "deployment".

After merging this patch, defaults will be the same, but we'll be able
to override them independently of deploymentType.
  • Loading branch information
rsicart authored and JAORMX committed Apr 15, 2024
1 parent 786a6a7 commit 5b52361
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 0 additions & 2 deletions templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,10 @@ spec:
selector:
matchLabels:
{{- include "krakend.selectorLabels" . | nindent 6 }}
{{- if eq .Values.deploymentType "rollout" }}
{{- with .Values.strategy }}
strategy:
{{- toYaml . | nindent 4 }}
{{- end }}
{{- end }}
template:
metadata:
annotations:
Expand Down
3 changes: 3 additions & 0 deletions values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ deploymentType: deployment
# a `deployment` or a `rollout` strategy.
# For more information on the Argo Rollout strategy, see https://argo-rollouts.readthedocs.io/en/stable/features/specification/
strategy: {}
# rollingUpdate:
# maxSurge: 25%
# maxUnavailable: 10%

krakend:
# -- (bool) Whether the given krakend image to be used contains everything needed
Expand Down

0 comments on commit 5b52361

Please sign in to comment.