Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Equinix TF Modules examples/ conventions (using existing samples) #66

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

displague
Copy link
Member

@displague displague commented May 15, 2023

Apply Equinix TF Modules examples/ conventions (using existing samples).

For more on the conventions, see https://github.com/equinix-labs/equinix-labs/blob/main/terraform-modules.md; not all applied in this PR. More could be pulled in through adopting some of the CI and practices from https://github.com/equinix-labs/terraform-equinix-template/.

Removes managed storage options.

Continues #63

Fixes #60

Blocked by:

Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
@displague displague changed the title Create examples (using existing samples) Apply Equinix TF Modules examples/ conventions (using existing samples) May 15, 2023
@@ -245,72 +245,38 @@ root@controller:~# openstack server list

## External Networking Support

External (Provider) networking allows VMs to be assigned Internet addressable floating IPs. This allows the VMs to offer Internet accessible services (i.e. SSH and HTTP). This requires the a block of IP addresses from Equinix Metal (elastic IP address). These can be requested through the Equinix Metal Web GUI. Please see https://www.packet.com/developers/docs/network/basic/elastic-ips/ for more details. Public IPv4 of at least /29 is recommended. A /30 will provide only a single floating IP. A /29 allocation will provide 5 floating IPs.
External (Provider) networking allows VMs to be assigned Internet addressable floating IPs. This allows the VMs to offer Internet accessible services (i.e. SSH and HTTP). This requires the a block of IP addresses from Equinix Metal (elastic IP address). These can be requested through the Equinix Metal Web GUI. Please see <https://metal.equinix.com/developers/docs/networking/elastic-ips/> for more details. Public IPv4 of at least /29 is recommended. A /30 will provide only a single floating IP. A /29 allocation will provide 5 floating IPs.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL could be updated to deploy. Redirects may handle it for now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
External (Provider) networking allows VMs to be assigned Internet addressable floating IPs. This allows the VMs to offer Internet accessible services (i.e. SSH and HTTP). This requires the a block of IP addresses from Equinix Metal (elastic IP address). These can be requested through the Equinix Metal Web GUI. Please see <https://metal.equinix.com/developers/docs/networking/elastic-ips/> for more details. Public IPv4 of at least /29 is recommended. A /30 will provide only a single floating IP. A /29 allocation will provide 5 floating IPs.
External (Provider) networking allows VMs to be assigned Internet addressable floating IPs. This allows the VMs to offer Internet accessible services (i.e. SSH and HTTP). This requires the a block of IP addresses from Equinix Metal (elastic IP address). These can be requested through the Equinix Metal Web GUI. Please see <https://deploy.equinix.com/developers/docs/metal/networking/elastic-ips/> for more details. Public IPv4 of at least /29 is recommended. A /30 will provide only a single floating IP. A /29 allocation will provide 5 floating IPs.

@@ -10,7 +10,8 @@ In each example, there is a module declaration such as:
variable "metal_auth_token" {}

module "openstack" {
source = "metal/openstack/metal"
# source = "../.."
source = "equinix/openstack/metal"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project should get moved to equinix-labs and be renamed to terraform-equinix-metal-openstack

@displague
Copy link
Member Author

If not in this PR, than in a successor, the provider definition should move into the examples/ and the README.md should give instruction to run the project from the examples.

@displague displague added the area/ci-cd-release Related to the integration, deployment, or release processes label May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci-cd-release Related to the integration, deployment, or release processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove block storage dependency
1 participant