Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removing the obsolete PromptUI library from the project. #407

Merged
merged 1 commit into from
Dec 14, 2023
Merged

fix: removing the obsolete PromptUI library from the project. #407

merged 1 commit into from
Dec 14, 2023

Conversation

codinja1188
Copy link
Contributor

What fixes the PR?

#331

@codinja1188 codinja1188 marked this pull request as ready for review December 13, 2023 14:58
@codinja1188 codinja1188 changed the title fix: Eliminate the obsolete PromptUI library from the project. fix: removing the obsolete PromptUI library from the project. Dec 13, 2023
displague
displague approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@displague displague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an opportunity to park the common code in a package, but I'm not concerned for this PR.

@displague
Copy link
Member

displague commented Dec 14, 2023 •
edited
Loading 

=== RUN   TestCli_Devices_Update/reinstall_device
Error when calling `DevicesApi.FindDeviceById`: 403 Forbidden You are not authorized to view this device
Error when calling `DevicesApi.FindDeviceById`: 403 Forbidden You are not authorized to view this device
    device_reinstall_test.go:53: 403 Forbidden You are not authorized to view this device
--- FAIL: TestCli_Devices_Update (105.81s)
    --- FAIL: TestCli_Devices_Update/reinstall_device (105.81s)
FAIL

Not related to this PR, but worth looking into. (@aayushrangwala is this something you're running into in #343?)

@displague displague merged commit d82cb24 into equinix:main Dec 14, 2023
8 of 9 checks passed
This was referenced Dec 14, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@displague displague displague approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codinja1188 @displague