Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: setup semantic release GHA #154

Merged
merged 3 commits into from
Feb 15, 2024
Merged

ci: setup semantic release GHA #154

merged 3 commits into from
Feb 15, 2024

Conversation

t0mk
Copy link
Contributor

@t0mk t0mk commented Feb 13, 2024

This PR changes the release GHA so that the version number is derived from history using semantic-release github action. It create GitHub release and uploads collection to Galaxy.

In addtion

  • I had to bump ansible in requirements-dev because old ansible-galaxy cli tool didn't work with current Ansible Galaxy API. Let's see if integration tests pass.
  • I fixed link to collection docs on GitHub.

fixes #132 and #152

@t0mk
Copy link
Contributor Author

t0mk commented Feb 13, 2024

Integration tests fail because Ansible 7.5.0 needs Python 3.10. We have Ansible 7.5.0 as dev-requirement so that we can use ansible-galaxy to upload the collection. Integration tests have Python 3.8 hardcoded right now.

To resolve this, I think we have to bump integration tests action to Python 3.10 and declare that we officially support Python 3.10. anible-galaxy collection publish will not work with Ansible lower than 7.5.0 and Ansible 7.5.0 needs PYthon 3.10.

edit: Ansbile 7.5.0 needs Python 3.9
https://github.com/ansible-community/ansible-build-data/blob/15d59523ce2da44201f6d6708c8cdc4d9de0d539/7/ansible-7.5.0.deps#L3

@ctreatma
Copy link
Contributor

Before setting up a semantic release action we'll need to add a GHA workflow to enforce Conventional Commit tags in PR titles so that the semantic release action can use those to calculate the next version.

ctreatma added a commit that referenced this pull request Feb 13, 2024
This PR bumps Python version used in integration tests to 3.10. We might
need it if we want to use GHA to publish collection to Galaxy.

Related to #154
@t0mk
Copy link
Contributor Author

t0mk commented Feb 14, 2024

@ctreatma good point. I just created #156

@ctreatma ctreatma merged commit b7384b6 into main Feb 15, 2024
3 checks passed
@ctreatma ctreatma deleted the semanticrelease branch February 15, 2024 16:27
Copy link

This PR is included in version 0.4.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module docs in Ansible Galaxy are not rendered properly
2 participants