Add manual trigger for integration test workflow for PRs #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
displague
reviewed
Aug 4, 2023
| run: pip3 install -r requirements-dev.txt -r requirements.txt | ||
|
|
||
| - name: install ansible dependencies | ||
| run: ansible-galaxy collection install amazon.aws:==6.0.1 |
There was a problem hiding this comment.
I think I've asked about this before.. Any idea why we need AWS here?
|
@ctreatma added a pattern in equinix/metal-cli that could be helpful here: https://github.com/equinix/metal-cli/blob/main/.github/workflows/e2e-test.yml Described here: equinix/metal-cli#306 |
Hmm, that looks more simple than the the Linode workflow. |
|
@displague I redid the workflow in a similar manner as the one in metal-cli. It's actually the same except for trigger paths and the last text execution block. |
ctreatma
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds workflow to run integration tests for a PR. It doens't run the tests automatically but it's triggered manually, from Actions section of the repo, and it's got params test, hash, PR num.
I think only people with write access to the repo can trigger the test. I'm not sure if this is a good thing as Equinix Metal integration tests can flaky, as we know from the TF provider.
It's taken from Linode ansible collection.